Firewall rule: Create separator to ease the rule sorting

stephdl commented 3 years ago

You might have a lot of rules in the Firewall rule panel, you can find it with the search function, but sometimes getting something to separate group of rules could be nice to have.

Proposed solution

I propose to create separators inside the rule firewall panel, like this we might separate a group of rules, this solution is implemented in opensense or some firewall distribution.

Alternative solutions

do nothing

Additional context

Screenshot - 2021-11-19T114336 379

thank to @cotosso @francio87

nethbot commented 3 years ago

in 7.9.2009/testing:

nethserver-firewall-base-3.17.4-1.8.gc63c899.ns7.noarch.rpm x86_64 armhfp aarch64
nethserver-firewall-base-ui-3.17.4-1.8.gc63c899.ns7.noarch.rpm x86_64 armhfp aarch64

gsanchietti commented 3 years ago

Test case 1

Update an existing machine
Access the Firewall Rules page
Add, modify, delete and reorder a 2 or more separators
Verify the rules are not modified

Test case 2

Try do add and delete rules also from Local rules page, Traffic shaping and Squid bypass
Verify everything works as expected

francio87 commented 3 years ago

Test case 1 : ok

Test case 2 :

I can add, delete and reorder rules from Traffic Shaping without issue, same for Squid bypass, i can add or remove rules.

If there are 1 or more Separator on Rules, i can't access Local Rules page anymore:

sep_local_rules

Firefox Console log:

TypeError: e.Action is undefined
    mapTitleAction LocalRules.vue:970
    Be LocalRules.vue:1
    ki chunk-vendors.996a0262.js:17
    Be LocalRules.vue:1
    _render chunk-vendors.996a0262.js:17
    n chunk-vendors.996a0262.js:17
    get chunk-vendors.996a0262.js:17
    run chunk-vendors.996a0262.js:17
    ti chunk-vendors.996a0262.js:17
    he chunk-vendors.996a0262.js:17
    oe chunk-vendors.996a0262.js:17
    promise callback*te chunk-vendors.996a0262.js:17
    he chunk-vendors.996a0262.js:17
    oi chunk-vendors.996a0262.js:17
    update chunk-vendors.996a0262.js:17
    notify chunk-vendors.996a0262.js:17
    set chunk-vendors.996a0262.js:17
    set chunk-vendors.996a0262.js:17
    getRules LocalRules.vue:1858
    exec nethserver.js:108
    s cockpit.min.js:962
    f cockpit.min.js:974
    n cockpit.min.js:880
    setTimeout handler*L cockpit.min.js:885
    f cockpit.min.js:973
    l cockpit.min.js:997
    e cockpit.min.js:1024
    spawn cockpit.min.js:2067
    se cockpit.min.js:76
    e cockpit.min.js:205
    p cockpit.min.js:590
    m cockpit.min.js:599
    v cockpit.min.js:493
    dispatch_data cockpit.min.js:423
chunk-vendors.996a0262.js:17:11122
    Qt chunk-vendors.996a0262.js:17
    Kt chunk-vendors.996a0262.js:17
    Zt chunk-vendors.996a0262.js:17
    _render chunk-vendors.996a0262.js:17
    n chunk-vendors.996a0262.js:17
    get chunk-vendors.996a0262.js:17
    run chunk-vendors.996a0262.js:17
    ti chunk-vendors.996a0262.js:17
    he chunk-vendors.996a0262.js:17
    oe chunk-vendors.996a0262.js:17
    (Asinc.: promise callback)
    te chunk-vendors.996a0262.js:17
    he chunk-vendors.996a0262.js:17
    oi chunk-vendors.996a0262.js:17
    update chunk-vendors.996a0262.js:17
    notify chunk-vendors.996a0262.js:17
    set chunk-vendors.996a0262.js:17
    set chunk-vendors.996a0262.js:17
    getRules LocalRules.vue:1858
    exec nethserver.js:108
    s cockpit.min.js:962
    f cockpit.min.js:974
    n cockpit.min.js:880
    (Asinc.: setTimeout handler)
    L cockpit.min.js:885
    f cockpit.min.js:973
    l cockpit.min.js:997
    e cockpit.min.js:1024
    spawn cockpit.min.js:2067
    se cockpit.min.js:76
    e cockpit.min.js:205
    p cockpit.min.js:590
    m cockpit.min.js:599
    v cockpit.min.js:493
    dispatch_data cockpit.min.js:423

nethbot commented 3 years ago

in 7.9.2009/testing:

nethserver-firewall-base-3.17.4-1.13.gd838bf0.ns7.noarch.rpm x86_64 armhfp aarch64
nethserver-firewall-base-ui-3.17.4-1.13.gd838bf0.ns7.noarch.rpm x86_64 armhfp aarch64

gsanchietti commented 3 years ago

Back to testing @francio87

francio87 commented 3 years ago

Test case 1 : Ok Test case 2 : Ok, local rules issue fixed

ok_local_rules

nethbot commented 2 years ago

in 7.9.2009/updates:

nethserver-firewall-base-3.18.0-1.ns7.noarch.rpm x86_64 armhfp aarch64
nethserver-firewall-base-ui-3.18.0-1.ns7.noarch.rpm x86_64 armhfp aarch64

NethServer / dev

Firewall rule: Create separator to ease the rule sorting #6602