NethServer / dev

NethServer issue tracker
https://github.com/NethServer/dev/issues
63 stars 20 forks source link

LE certificate request requires a FQDN #6853

Closed stephdl closed 4 months ago

stephdl commented 4 months ago

Steps to reproduce

Expected behavior

I expect to request a Let's encrypt certificate with the hostname foo

Actual behavior

Request a lest encrypt certificate needs several conditions but at least it won't never give with a hostname, it requires a fully qualified domain name as foo.com. The actual validator should block us and require a domain foo.com or a FQDN server.foo.com

Components

we have a lot module or core product impacted, in fact we used to validate with json schema like this

"format": "idn-hostname" "format": "hostname"

See also

https://mattermost.nethesis.it/nethesis/pl/k95kbw8ft3yf5gdtutwgszg18e


thank @lucagasparini

stephdl commented 4 months ago
DavidePrincipi commented 4 months ago

VERIFIED

The patch was verified for NextCloud https://github.com/NethServer/dev/issues/6865#issuecomment-1968792504

Let's close this issue. We will release individual modules in the upcoming weeks.

stephdl commented 4 months ago

closed, each module will be tested by the developer itself when a new release will occur