Multi Node environment doesn't return facts correctly

[Tbaile]

Steps to reproduce

• create a multi-node cluster
• call from leader node api-cli run cluster/get-facts | jq '.facts.nodes | length'

Expected behavior

The returning value should be the number of nodes in the cluster

Actual behavior

"1" is returned, which is the last node to have answered the get-facts command

Components

NS8 2.7.0

See also

PR related: https://github.com/NethServer/ns8-core/pull/631

[DavidePrincipi]

In testing as core 2.8.0-dev.8

Test the bug isn't reproducible

[DavidePrincipi]

VERIFIED

The bug is fixed, however the lspci command may not be present on some very old nodes:

# runagent lspci
Traceback (most recent call last):
  File "/usr/local/bin/runagent", line 92, in <module>
    os.execvp(args.COMMAND, [args.COMMAND] + args.ARGS)
  File "<frozen os>", line 574, in execvp
  File "<frozen os>", line 616, in _execvpe
  File "<frozen os>", line 607, in _execvpe
FileNotFoundError: [Errno 2] No such file or directory

See https://github.com/search?q=repo%3ANethServer%2Fns8-core+lspci&type=code

[Tbaile]

This is indeed weird, pciutils package is installed in both Debian and Rocky, any leads on the why?

Noticed now the very old nodes part, indeed it is, we have no control in installing packages after the first installation, might be useful in the future such mechanism

[Tbaile]

Might add the package installation under the update-core.d, tell me if it's the right place

[DavidePrincipi]

There's no need to implement it here. Let's release the fix as is.

[DavidePrincipi]

Released Core https://github.com/NethServer/ns8-core/releases/tag/2.8.0