NethServer / dev

NethServer issue tracker
https://github.com/NethServer/dev/issues
63 stars 20 forks source link

Orphan App is not listed in Software Center #6947

Closed DavidePrincipi closed 1 week ago

DavidePrincipi commented 2 weeks ago

An instance of application that does not belong to any enabled repository is not accessible from the Software Center and cannot be removed.

Steps to reproduce

Expected behavior

App instances under Software Center > Installed are visible. They can be also removed.

Actual behavior

The Software Center is empty. The App Grid still lists the instances.

image

Components

Core 2.8.2

See also

https://community.nethserver.org/t/ns8-unable-to-remove-app-from-ui-when-its-repository-is-disabled/23108


Thanks to @dnutan

compgeniuses commented 2 weeks ago

i was under the impression that this was a Feature and Not a bug.

Basically, if we install Apps via the command line, the Apps do not Appear on Software center, however, they do appear on the Applist grid.

Equally, when an App repository is removed, the App is deemed to have been removed, and therefore does ot appear in Software center, and therefore, not possible to remove it via the software centre.

What would be a Bug, in my opinion based on the current implementation is if, the software repo is re-enabled, and the app is still not visible in software center, and not possible to remove from the same interface.

What do you think?

DavidePrincipi commented 2 weeks ago

The Software Center displays Applications and their Instances. It is not only a list of software from enabled repositories, it provides actions like Clone/Move Edit Label and Remove over individual instances.

Such actions are no longer available when a repository is disabled: it is wrong. Hence it is a bug.

DavidePrincipi commented 2 weeks ago

Test case

In Core ~2.8.4-dev.1~ 2.8.4-dev.2

Test the bug isn't reproducible, and the expectation works.

DavidePrincipi commented 1 week ago

Fixed sort error https://community.nethserver.org/t/ns8-unable-to-remove-app-from-ui-when-its-repository-is-disabled/23108/6?u=davidep

See commit https://github.com/NethServer/ns8-core/commit/0600fbc45b7f179eed15727f450a29d02b6dcdb9

Repeat test case with Core 2.8.4-dev.2

DavidePrincipi commented 1 week ago

Released in https://github.com/NethServer/ns8-core/releases/tag/2.8.4