OpenVPN tunnel client: device always forced to "tap"

cotosso commented 1 month ago

Steps to reproduce

Import an Openvpn tunnel client or configure a new one from scratch.
Edit configuration from web UI
open Advanced settings

select Routed Mode

Expected behavior

Tunnel configuration is created accordingly in the database:

option dev_type tun
option dev tun$NAME

Actual behavior The dev type is always set to tap instead of tun and the dev name is accordingly created (tap$NAME) regardless to the chosen mode (Bridged or Routed).

IMPORTANT It only happens if Advanced settings section has been opened, otherwise default tun is used.

Components

NethSecurity 8 23.05.4-ns.1.2.0-25-g2a6b69cd

Tbaile commented 1 month ago

Testing image: https://github.com/NethServer/nethsecurity/actions/runs/10812881491/artifacts/1919729133

cotosso commented 1 month ago

I tested the image: The proposed fix solved the problem, now configuration file is written accordingly to what is present in the web UI.

NethServer / nethsecurity

OpenVPN tunnel client: device always forced to "tap" #743