search

NethServer / nethsecurity

NethSecurity image and build environment
https://www.nethsecurity.org/
Other
99 stars 5 forks source link

Thread Shield: MAC address with description Ignored on allowed list #813

Open gsanchietti opened 3 weeks ago

gsanchietti commented 3 weeks ago

On the "Thread Shield" page, under the "Allowed List" tab, there is an issue where entering a MAC address along with a description causes the MAC address to be ignored. However, when the MAC address is entered without a description, it is accepted without issues.

Steps to Reproduce:

  1. Navigate to the "Thread Shield" page.
  2. Click on the "Allowed List" tab.
  3. Enter a valid MAC address along with a description.
  4. Attempt to save the entry.

Expected Result:
The MAC address should be saved along with its description.

Actual Result:
The MAC address is ignored, and the entry is not saved.

Additional Information:
This issue appears to be an upstream bug related to BanIP.

Components

NethSecurity 23.05.4

cotosso commented 2 weeks ago

BanIP currently doesn't support comments for MAC addresses in the allowlist.

However there is a good chance that this feature will be added with the upcoming banIP updates. As it is quite a rare use case, for the moment, we won't make any changes to NethSecurity UI and will wait for further developments on banIP.

As soon as there will be updates from banIP we will fix the bug definitively (at that point it might already be solved automatically).

cotosso commented 2 weeks ago

BanIP updated to 1.0.0.8 introduced comments for MAC Address in allowlist and blocklist:

https://github.com/openwrt/packages/commit/270e6f12644eb0ba3b1596cb73e267edf3980570#diff-8589640d502b0bdc4a42cc843a706e764dc770b314b1ba017692c1cbc68647a5

gsanchietti commented 1 week ago

We can either fork the package to import inside current version, or wait upstream to release on the stable tag

cotosso commented 1 week ago

I tested the new version and it works flawlessy. Cause this kind of feature is not so urgent (we can still use mac address without comments) we decided to wait for the stable upstream release at most until the release of nethsecurity 8.4. At that point if we still don't have a stable upstream we'll fork the package to import inside current version.