search

NetherGamesMC / PocketMine-MP

A multi protocol server software for Minecraft: Bedrock Edition in PHP
https://pmmp.io
GNU Lesser General Public License v3.0
84 stars 97 forks source link

PM5 is bugged #321

Closed Lunarelly closed 1 year ago

Lunarelly commented 1 year ago

TypeConverter::getInstance()->setSkinAdapter() affects only LATEST version Players who are not on latest (<1.19.80) somehow got 4 sticks in crafting grid

Lunarelly commented 1 year ago

alright its because TypeConverter is not a single instance,

dries-c commented 1 year ago

getInstance() always uses the latest version. Ideally you would set this on every instance using TypeConverter::getAll(true), since the SkinAdapter might be different depending on the version of Minecraft you're using