search

NetherGamesMC / PocketMine-MP

A multi protocol server software for Minecraft: Bedrock Edition in PHP
https://pmmp.io
GNU Lesser General Public License v3.0
78 stars 97 forks source link

BlockStateDowngrader: fix the downgrade of blocks with copied states #332

Closed Blackjack200 closed 1 year ago

Blackjack200 commented 1 year ago

Introduction

This PR fixes fix the downgrade of blocks with copied states, like oak_log to log

Relevant issues

Changes

API changes

No

Behavioural changes

the BlockStateDowngrader works properly now.

Backwards compatibility

Any patch to BlockStateDowngrader may need an update. Others have no impact.

Follow-up

Nothing

Requires translations: No

Tests

Tested with oak_log and join server with version 575, it works.

dries-c commented 1 year ago

Could you fill in the template?

Blackjack200 commented 1 year ago

Could you fill in the template?

filled

dries-c commented 1 year ago

Instead of downgrading, i'm rewriting the system to only use upgrading so the items that aren't supported don't appear.