juanfranblanco
commented
6 years ago In what scenario you see this? There is not much (if any) error handling in the sample. But when a transaction is sent, the transaction hash is put in the bus.
Open mwherman2000 opened 6 years ago
juanfranblanco
commented
6 years ago In what scenario you see this? There is not much (if any) error handling in the sample. But when a transaction is sent, the transaction hash is put in the bus.
mwherman2000
commented
6 years ago Sending a plain old transaction on mainnet. I did add something to the extra data field:
badbad
The value/amount was 0.001 and the rest was defaulted.
juanfranblanco
commented
6 years ago I guess the extra data might have made the transaction to be rejected, and removed from pending before being able to retrieve it. So yes a null check might come handy there.
Parameter transaction is null when TransactionViewModel.Initialize(transaction) is called from MessageBus.Current.Listen() in class TransactionsViewModel... Here is a copy of the calling code:
MessageBus.Current.Listen().Subscribe(async x =>
{
if (Util.Utils.IsValidUrl(Url))
{
var web3 = new Web3.Web3(Url);
var transactionViewModel = new TransactionViewModel();
var transaction = await web3.Eth.Transactions.GetTransactionByHash.SendRequestAsync(x.TransactionHash);
transactionViewModel.Initialise(transaction);
transactionViewModel.Status = TransactionViewModel.STATUS_INPROGRESS;
lock (receiptsCheckLock)
{
Transactions.Add(transactionViewModel)
}
}
});