NetherlandsForensicInstitute / kafka-spout

Kafka consumer emitting messages as storm tuples
Apache License 2.0
103 stars 73 forks source link

Allows caller to use a different constructor to pass in a topic name, pr... #9

Closed sandonjacobs closed 10 years ago

sandonjacobs commented 10 years ago

Support for multiple instances of KafkaSpout in a single topology by passing topic name on the constructor.

akaIDIOT commented 10 years ago

I like this idea, thanks :)

Unfortunately, it'll be Monday before I get a chance to look at this closely. For now, could you add a commit to remove the underscores from the method names in your added unit test?

sandonjacobs commented 10 years ago

As requested, I removed the underscores from the test method names. Thanks...

akaIDIOT commented 10 years ago

Haven't been able to test this on our deployment, but it looks all right and likely useful in general. Thanks for your efforts :)

sandonjacobs commented 10 years ago

Thanks Mattijs...