search

NethermindEth / Paprika

A custom storage engine of Nethermind, benefiting from the alignment of the underlying data structure with the layout of State & Storage trees of Ethereum.
GNU Lesser General Public License v3.0
91 stars 14 forks source link

Reduce usage of explicit disposable #406

Closed Scooletz closed 1 month ago

Scooletz commented 1 month ago

Some of the tests used explicit .Dispose that might show a case that this is how we want to use the IDisposable. Always, ALWAYS, prefer using var over an explicit that might be forgotten and result in some leakage. Especially when readonly tx are used.

github-actions[bot] commented 1 month ago

Code Coverage

Package Line Rate Branch Rate Health
Paprika 85% 80% ➖
Summary 85% (4604 / 5430) 80% (1473 / 1843) ➖

Minimum allowed line rate is 75%