search

NethermindEth / StarknetByExample

A collection of examples of Cairo smart contracts for Starknet.
https://starknet-by-example.voyager.online/
MIT License
103 stars 78 forks source link

[i18n] translate Spanish #142

Closed Nadai2010 closed 7 months ago

Nadai2010 commented 7 months ago

Description

Hi team, i add translation version Spanish

julio4 commented 7 months ago

LGTM! Thank you very much. Please review my comments in #133 but I believe you have already.

Nadai2010 commented 7 months ago

Hello @julio4 Sorry for not answering, I just only put 👍 in #133.

I agree to update the book every 15 - 30 days, if at any time you have a important update, you can tag us to know what is important and give priority if we can compared to the period of 15 to 30 days that we mentioned.

By the way: @cryptonerdcn or @julio4, I'm checking, did I miss any settings? I don't see the Spanish version added.

Very Thank you

cryptonerdcn commented 7 months ago

@Nadai2010 Oh bro you should not touch zh-cn.po because it will break something. You must add es to languages and UI to show the Spanish Version. I will make a PR for this. @julio4

Nadai2010 commented 7 months ago

Normally I only upload the po.es, but when creating the language from 0, I did the pr to update the message.pot and I don't know why the po.ch was updated, I didn't touch anything there 😅, sorry @cryptonerdcn

cryptonerdcn commented 7 months ago

Normally I only upload the po.es, but when creating the language from 0, I did the pr to update the message.pot and I don't know why the po.ch was updated, I didn't touch anything there 😅, sorry @cryptonerdcn

That's OK. Next time you can just commit es.po and reset zh-cn.po to default. It will work.

Nadai2010 commented 7 months ago

You're right, I'll be careful next time to not upload the rest of the changes. Thank you friend

julio4 commented 7 months ago

@cryptonerdcn @Nadai2010 Thank you both for the reactivity!

There's still an issue with the Spanish version @Nadai2010, where some parts are not translated well. Could you look into it?

Nadai2010 commented 7 months ago

Hi @julio4, I upload it in this PR #147, I don't know what happened but the file was broken, everything is corrected now.

Thank You