search

NethermindEth / StarknetByExample

A collection of examples of Cairo smart contracts for Starknet.
https://starknet-by-example.voyager.online/
MIT License
110 stars 84 forks source link

Standardize chapter-related folder names in */src* #211

Closed 0xNeshi closed 3 months ago

0xNeshi commented 4 months ago

TL;DR

Folder names for chapters should use actual names related to their subject's, like: getting-started, components, applications and advanced-concepts.

Folders in question are in /src: https://github.com/NethermindEth/StarknetByExample/tree/main/src

Context

Three out of four chapters use chXX format for their folder names and then there is one src/components folder: image

To make matters a bit more confusing, the correct order of the chapters is: ch00 > components > ch01 > ch02.

The folder names should be updated in the following way:

raizo07 commented 4 months ago

@misicnenad I'll like to work on this

0xNeshi commented 4 months ago

@raizo07 just create a draft PR and link this issue, I'll review

raizo07 commented 4 months ago

@raizo07 just create a draft PR and link this issue, I'll review

Alright, I will.

raizo07 commented 3 months ago

@misicnenad Here's a link to the draft PR kindly review https://github.com/NethermindEth/StarknetByExample/pull/216

0xNeshi commented 3 months ago

Thanks @raizo07, left a comment for you in the PR

raizo07 commented 3 months ago

Thanks @raizo07, left a comment for you in the PR

Alright I'll check it out.

julio4 commented 3 months ago

Completed in #216