NethermindEth / Taiko-Preconf-AVS

11 stars 6 forks source link

Deprecated: Reuse storage slots with ring-buffers #169

Closed dantaik closed 16 hours ago

dantaik commented 1 day ago

See https://github.com/taikoxyz/Taiko-Preconf-AVS-copy/discussions/11

Reduce SSTORE from 20K to 5K for lookaheadPosters and blockIdToProposer

AnshuJalan commented 1 day ago

Thank you for the changes! I have raised an alternative PR (#171) with two additional commits on top of yours:

dantaik commented 16 hours ago

Closed and will continue on https://github.com/NethermindEth/Taiko-Preconf-AVS/pull/171

dantaik commented 16 hours ago

LOOKAHEAD_POSTER_BUFFER_SIZE: I did not completely understand the reason behind using PreconfConstants.SECONDS_IN_SLOT * BLOCK_ID_TO_PROPOSER_BUFFER_SIZE as the value in your commit.

This is incorrect in my previous PR. No need to have SECONDS_IN_SLOT in the calculation at all. Good catch.

dantaik commented 16 hours ago

Lets switch to discuss in your new PR.