search

NethermindEth / blockifier-tester

A testing utility to run juno with our version of the blockifier that uses cairo native, and compare it to results from mainnet or from juno using the unmodified blockifier
1 stars 1 forks source link

Kill juno instances on `SIGTERM` #49

Closed xrvdg closed 3 months ago

xrvdg commented 3 months ago

On killing the blockifier-tester with crtl+c/SIGTERM the spawned juno subprocess becomes an orphan. That's how UNIX subprocesses work, they continue to live on without their parent. But in our case this is undesirable because the reason you are killing the blockifier-tester is because you want to kill the juno instance.

xrvdg commented 3 months ago

Tried using the ctrlc crate for the signal handler, but that didn't work as desired. Since the tester uses tokio it's probably better to use tokio::signal for the signal handler.