Closed marcuspang closed 5 days ago
How should conflicting calls be handled? If base has [(ch1, ep1), (ch2, ep2)] and native has [(ch1, ep1)], do we return a count of 1 or 2 for (ch1, ep1) (currently taking the sum in merge_calls_with_count)
A count of 1 for (ch1, ep1). We ignore (ch2, ep2) since there is no data
If (ch1, ep1) and (ch1, ep2) that's a different Pair and cannot be compared. You can only compare "same keys" like when (ch_i, ep_k) exists in both.
Fixes #85
Changes
get_calls_with_count
now returns aHashMap<(EntryPoint, ClassHash), usize>
get_calls
, which returned a list of possible tuple values, but I chose to return the concrete(EntryPoint, ClassHash)
pairs instead for clarityValue
parsing, which can now parse keys that have"Same(0x123)"
values"0x123"
values, which meant that the parsing of some calls terminated early because of the"Same"
prefixget_calls_with_count
and added some for helper functionsNotes
[(ch1, ep1), (ch2, ep2)]
and native has[(ch1, ep1)]
, we only count(ch1, ep1)
pair once"Empty"
or[]
, thenget_calls_with_count
will return[]