NethermindEth / blockifier

Blockifier is a Rust implementation for the transaction-executing component in the StarkNet sequencer, in charge of creating state diffs and blocks.
Apache License 2.0
1 stars 4 forks source link

erc20 code review #10

Closed DomHenderson closed 7 months ago

DomHenderson commented 7 months ago

reviewed everything except some of the contents of the erc20_tests

change token name from Native to oz_erc20 delete unused sierra file add starknet version into scarb toml SierraContractClass::constructor_selector method entrypoints_by_type to entry_points_by_type to match existing code unwrap entry_point_selector after it gets passed into setup_syscall_handler to keep more descriptive parameter type extra conversion helpers, and one to parse error message felts unnested a lot of get_execution_info for legibility filled in the l1 handler case for match_entrypoint and simplified removed commented code simplified a few type conversions added a test mod for making sure that the returned error felts do say what is expected