search

NethermindEth / blockifier

Blockifier is a Rust implementation for the transaction-executing component in the StarkNet sequencer, in charge of creating state diffs and blocks.
Apache License 2.0
1 stars 3 forks source link

fix: zero caller address being propagated #87

Closed DomHenderson closed 1 month ago

DomHenderson commented 1 month ago

Previously we were passing the current caller address as the caller address for the call generated from call_contract. Instead, we should be passing the current address as it is the one calling the target contract. A little extra testing is added here for get_execution_info (which is used for getting the caller address), though more should be added in time

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.84%. Comparing base (3844200) to head (1d525ac).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## native2.6.3 #87 +/- ## =============================================== + Coverage 78.33% 78.84% +0.50% =============================================== Files 77 77 Lines 10652 10653 +1 Branches 10652 10653 +1 =============================================== + Hits 8344 8399 +55 + Misses 1843 1785 -58 - Partials 465 469 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.