search

NethermindEth / blockifier

Blockifier is a Rust implementation for the transaction-executing component in the StarkNet sequencer, in charge of creating state diffs and blocks.
Apache License 2.0
1 stars 3 forks source link

fix: native secp256k1 and secp256r1 #93

Closed xrvdg closed 2 weeks ago

xrvdg commented 2 weeks ago

Fix: #60

The x and y point required an extra conversion to get the same result as native. The previous code bypassed the conversion by directly accessing the underlying BigInt of the point.

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.84%. Comparing base (3b16c2a) to head (f191f61).

Files Patch % Lines
...blockifier/src/execution/native/syscall_handler.rs 93.33% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## native2.6.3 #93 +/- ## =============================================== + Coverage 78.84% 79.84% +1.00% =============================================== Files 77 77 Lines 10653 10607 -46 Branches 10653 10607 -46 =============================================== + Hits 8399 8469 +70 + Misses 1785 1667 -118 - Partials 469 471 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.