search

NethermindEth / cairo-vm-go

A virtual machine for Cairo written in Go
MIT License
81 stars 50 forks source link

Sqrt #240

Closed cicr99 closed 5 months ago

cicr99 commented 6 months ago

Calculates the square root of a given value, ensuring it falls within a specific range.

Reference: https://github.com/starkware-libs/cairo-lang/blob/efa9648f57568aad8f8a13fbf027d2de7c63c2c0/src/starkware/cairo/common/math.cairo#L423

It will probably be useful to have a look into hintrunner/core/FieldSqrt.

Tomi-3-0 commented 6 months ago

Hello @cicr99, I would like to start working on this

cicr99 commented 6 months ago

Perfect @Tomi-3-0, just assigned you to the task. Please review this guide on how to implement new Cairo 0 hints and let us know if you have any questions

Tomi-3-0 commented 6 months ago

Hello @cicr99. I submitted a PR for this issue. Please review. Thank you!

Tomi-3-0 commented 6 months ago

Hi @cicr99. I opened a fresh PR for this issue with the requested changes. Please review

cicr99 commented 5 months ago

Perfect. Great work! Pr approved and merged!