search

NethermindEth / cairo-vm-go

A virtual machine for Cairo written in Go
MIT License
79 stars 49 forks source link

Docs: Add builtins documentation for cairo vm #379

Closed jimenezz22 closed 3 months ago

jimenezz22 commented 3 months ago

This PR is for the issue Builtins Documentation #326. Adding a complete documentation to understand how builtins works on cairo virtual machine and how bulitins perform complex operations at the cost of extra constraints when proving.

jimenezz22 commented 3 months ago

Hi! @rodrigo-pino I'm working on the changes and will make a new commit as soon as possible. Sorry for the use of analogies, I used them because it is easier for me to understand these types of concepts through the use of analogies and I thought it would be good to include them in the documentation. I will make documentation cleaner, shorter and with more technical language.

jimenezz22 commented 3 months ago

@rodrigo-pino I already made the commit with the requested changes

jimenezz22 commented 3 months ago

Hi! @rodrigo-pino I'll make a new commit as soon as possible

rodrigo-pino commented 3 months ago

@jimenezz22 do you have any updates on this?

jimenezz22 commented 3 months ago

@rodrigo-pino I was waiting for you to answer the questions I had about the comments. In the next few hours you will have the issue ready

jimenezz22 commented 3 months ago

@rodrigo-pino new commit ready

jimenezz22 commented 3 months ago

@rodrigo-pino Changes made! Waiting for approval.