search

NethermindEth / cairo-vm-go

A virtual machine for Cairo written in Go
MIT License
79 stars 49 forks source link

SquashDictInnerNextKey #380

Closed HumbertoTM10 closed 3 months ago

HumbertoTM10 commented 3 months ago

Resolves #303

Added Squash Dict Inner Next Key.

har777 commented 3 months ago

Is this the right hint? https://github.com/NethermindEth/cairo-vm-go/issues/303 seems to point to https://github.com/starkware-libs/cairo-lang/blob/efa9648f57568aad8f8a13fbf027d2de7c63c2c0/src/starkware/cairo/common/squash_dict.cairo#L224 which is 

assert len(keys) > 0, 'No keys left but remaining_accesses > 0.'
ids.next_key = key = keys.pop()
MaksymMalicki commented 3 months ago

Yeah, someone else has implemented that code in this PR, for this issue

cicr99 commented 3 months ago

I'm closing this PR due to inactivity here. Anyway, it might be best to open a new PR for this issue, as the implementation does not coincide with the hint to be implemented