search

NethermindEth / cairo-vm-go

A virtual machine for Cairo written in Go
MIT License
79 stars 49 forks source link

Move GetConsecutiveValues functionality to memory package #384

Closed cicr99 closed 3 months ago

cicr99 commented 3 months ago

Currently GetConsecutiveValues functionality (and similar ones) are implemented in the hintrunner/hinter/operand.go file. The ideal place for them to be is the memory package. Moving these functionalities there implies doing modifications to several files, as lots of hints use them.

Leaving them where they are is currently a problem. See PR #354

murluki commented 3 months ago

can you assign me, please?

TAdev0 commented 3 months ago

Hi @murluki , Actually someone is already working on it

MoigeMatino commented 3 months ago

Currently working on this cc @cicr99

TAdev0 commented 3 months ago

@MoigeMatino feel free to reach out if you have any issue

MoigeMatino commented 3 months ago

@MoigeMatino feel free to reach out if you have any issue

Thanks @TAdev0 . Just created a PR, getting some errors when running make unit, not sure how to solve those. I'd appreciate your help with those, thanks!