search

NethermindEth / cairo-vm-go

A virtual machine for Cairo written in Go
MIT License
79 stars 49 forks source link

feat: Run separate cairo integration test files as a separate Go test #392

Closed xiaolou86 closed 3 months ago

xiaolou86 commented 3 months ago

Resolves #201

First checking if the environment variable INTEGRATION_TESTS_FILTERS is set in the console. And if not, then load it from the .env file.

xiaolou86 commented 3 months ago

@rodrigo-pino @quasilyte @cicr99 Please help me to review. Thank you very much.

MaksymMalicki commented 3 months ago

Hey, I left a comment on the issue. Can you please check it?

xiaolou86 commented 3 months ago

@MaksymMalicki I have made this improvement. Thanks for your suggestion.

xiaolou86 commented 3 months ago

@rodrigo-pino I have refactored into an object Filter. Thank you very much for your suggestion and review.

TAdev0 commented 3 months ago

@xiaolou86 there is a linting error:

Error: Error return value of godotenv.Load is not checked (errcheck)

Can you resolve this?

xiaolou86 commented 3 months ago

Error: Error return value of godotenv.Load is not checked (errcheck)

@TAdev0 Done. Thank you very much.