feat: SquashDictInnerNextKey hint

NethermindEth / cairo-vm-go

A virtual machine for Cairo written in Go

MIT License

79 stars 49 forks source link

feat: SquashDictInnerNextKey hint #400

Closed TAdev0 closed 3 months ago

TAdev0 commented 3 months ago

Resolves #303

if we want tests to be really good, and check the value in the scope of the array of field elements keys after popping, i guess we should add a Case in varValueInScopeEquals for arrays of felts.

TAdev0 commented 3 months ago

@MaksymMalicki comments addressed.

now both key and keys are reassigned in scope, and ids.next_key in memory is key
Created a case for [] fp.Element in varValueInScopeEquals that uses an external library reflect . Code is straightforward, i think its ok? its for tests anyway

had also a small pointer error, i actually stored a pointer to key instead of key itself in scope, its corrected

rodrigo-pino commented 3 months ago

All looks good to me. Let's wait to merge Hari's PR and we add an integration test for this as well

As @TAdev0 pointed out, it doesn't make sense to have integration test for just one hint, since they are multiple hints involved