NethermindEth / cairo-vm-go

A virtual machine for Cairo written in Go

MIT License

82 stars 49 forks source link

Implement `SquashDictInnerCheckAccessIndex` hint #416

Closed TAdev0 closed 3 months ago

TAdev0 commented 4 months ago

Resolves #298

This PR implements SquashDictInnerCheckAccessIndex hint, which updates the access index during the dictionary squashing process

sweep-ai[bot] commented 4 months ago

Sweep: PR Review

Sweep is currently reviewing your pr...

TAdev0 commented 4 months ago

@rodrigo-pino ready for review

TAdev0 commented 4 months ago

@har777 just addressed all your comments! thanks for the feedback. Indeed the hint was wrongly implemented, it didnt update the array of felts in scope after popping an element. I added a test for current_access_indices array in scope, now it should be good :)

TAdev0 commented 3 months ago

@MaksymMalicki addressed your comments