Closed TAdev0 closed 1 month ago
MemcpyEnterScope hint is as follows:
MemcpyEnterScope
//> vm_enter_scope({'n': ids.len})
this means we are supposed to store the value len in the scope.
len
Currently, the hint impl does:
len, err := hinter.ResolveAsFelt(vm, len) if err != nil { return err } ctx.ScopeManager.EnterScope(map[string]any{"n": len}) return nil
This is not correct as it stores a *fp.Element instead of a fp.Element. Indeed, ResolveAsFelt returns a pointer.
*fp.Element
fp.Element
ResolveAsFelt
Test is also wrong, checking that the value in scope is equal to feltUint64(1) and feltUint64 also returns a pointer.
feltUint64(1)
feltUint64
Will address this in a dedicated PR.
MemcpyEnterScope
hint is as follows:this means we are supposed to store the value
len
in the scope.Currently, the hint impl does:
This is not correct as it stores a
*fp.Element
instead of afp.Element
. Indeed,ResolveAsFelt
returns a pointer.Test is also wrong, checking that the value in scope is equal to
feltUint64(1)
andfeltUint64
also returns a pointer.Will address this in a dedicated PR.