NethermindEth / cairo-vm-go

A virtual machine for Cairo written in Go
MIT License
73 stars 43 forks source link

Move `WriteUint256ToAddress` function to Memory package #427

Closed TAdev0 closed 1 month ago

TAdev0 commented 1 month ago

WriteUint256ToAddress function is currently defined in Hinter package in operand.go file. This is not the right place for this function, which writes some uint256 value to a specified memory address. Nothing related to operands.

  1. Move the function to the Memory package in the appropriate file
  2. Update the codebase where it is needed
EmmanuelAR commented 1 month ago

Heeey @TAdev0 can i work on this? I can start now

EmmanuelAR commented 1 month ago

Hey @TAdev0, thanks for the opportunity!

Do you have Telegram so I can contact you if I have a question?

Here's mine: https://t.me/EmmanuelDevCr

TAdev0 commented 1 month ago

please write any questions here so that everyone can follow what's going on with this issue

EmmanuelAR commented 1 month ago

excellent, working now...

EmmanuelAR commented 1 month ago

Hello team @TAdev0

Heres the pr for migrate WriteUint256ToAddress and also WriteToNthStructField function

Let me know once you can check! :)

PR: #428

EmmanuelAR commented 1 month ago

Also i fix this link in the readme file @TAdev0, you can see the change in the last commit of the pr #428

Screenshot 2024-05-23 232742

Pass link image

NEW LINK image

TAdev0 commented 1 month ago

428