Move WriteUint256ToAddress and WriteToNthStructField to memory package - Githubissues

NethermindEth / cairo-vm-go

A virtual machine for Cairo written in Go

MIT License

73 stars 43 forks source link

Move WriteUint256ToAddress and WriteToNthStructField to memory package #428

Closed EmmanuelAR closed 1 month ago

EmmanuelAR commented 1 month ago

Move WriteUint256ToAddress from hinter package to memory package
Move WriteToNthStructField from hinter package to memory package
IMPORTANT NOTE: I know that i dont have to move WriteToNthStructField but if i want to migrate the WriteUint256ToAddress i have to move WriteToNthStructField too, because inside in the WriteUint256ToAddress i have to call WriteToNthStructField ).
Fix the calls in the source code for the two functions (WriteUint256ToAddress, WriteToNthStructField )

Project build sucess: Test run sucess:

EmmanuelAR commented 1 month ago

Also i fix this link in the readme file @TAdev0

Screenshot 2024-05-23 232742

Pass link

NEW LINK

TAdev0 commented 1 month ago

@EmmanuelAR you just have a linting issue in the memory.go file, can you address this?

EmmanuelAR commented 1 month ago

Sure @TAdev0, let me check!!

EmmanuelAR commented 1 month ago

Hey @TAdev0 Heres the commit to fix the format in memory.go file Commit: https://github.com/NethermindEth/cairo-vm-go/pull/428/commits/b6a59082c65fd34c0e85164694e4b5376b945f2f

TAdev0 commented 1 month ago

thanks!

TAdev0 commented 1 month ago

Closes #426 Closes #427