chore: move `WriteToNthStructField()` to `memory.go`

NethermindEth / cairo-vm-go

A virtual machine for Cairo written in Go

MIT License

73 stars 43 forks source link

chore: move `WriteToNthStructField()` to `memory.go` #429

Closed princeibs closed 1 month ago

princeibs commented 1 month ago

Related issue

Closes #426

Description

Moved WriteToNthStructField() from hintrunner/hinter/operand.go to vm/memory/memory.go
Also moved the WriteUint256ToAddress() as well because it utilises WriteToNthStructField() internally.
Lastly, update usage of both WriteToNthStructField() and WriteUint256ToAddress() across the codebase.

TAdev0 commented 1 month ago

Hi @princeibs ,

i'm really sorry i didn't notify that both issues for WriteToNthStructField and WriteUint256ToAddress were related. Given the fact that another contributor pushed a PR before you, and that both PRs address the 2 functions, we will review his PR and close this one.

Again, really sorry, this is my fault. Feel free to check sometimes if there are some good first issues that you could grab in the future :)