search

NethermindEth / cairo-vm-go

A virtual machine for Cairo written in Go
MIT License
73 stars 43 forks source link

Poseidon hash builtin #437

Closed MaksymMalicki closed 4 weeks ago

MaksymMalicki commented 1 month ago

@cicr99 I used this implementation of hades permutation and poseidon hash (https://github.com/NethermindEth/juno/blob/main/core/crypto/poseidon_hash.go), which returns only the first element of the three elements state. I had to make some modifications inside and can't use it as a package rn. Is it ok to leave this copy-pasted code, or should I come up with sth else

TAdev0 commented 1 month ago

@MaksymMalicki can i start reviewing it as the final version?

MaksymMalicki commented 1 month ago

@TAdev0 yeah sure, just don't review the poseidon hash math itself, as I'm going to remove it entirely, once the new release of Juno with updated crypto package is out

TAdev0 commented 1 month ago

ok got it will review today