NethermindEth / cairo-vm-go

A virtual machine for Cairo written in Go
MIT License
73 stars 43 forks source link

Removed Unnecessary imports #443

Closed Sh0g0-1758 closed 4 weeks ago

Sh0g0-1758 commented 1 month ago

Just removed a double import. One time it was imported as fp and another as f.

TAdev0 commented 1 month ago

@Sh0g0-1758 yeah it happens in many files. I'm in favor of not merging this, as we currently have a few Dict related hints that use f.Element

merging this would lead to many conflicts, we should address this once all dict hints are merged

@cicr99

TAdev0 commented 4 weeks ago

@Sh0g0-1758 now we only have one dict hint , we can merge this i guess! can you update what needs to be updated to make it pass?

Sh0g0-1758 commented 4 weeks ago

I think the changes I intended to makes with this PR already happened in the previous PRs which you merged. Closing this.