NethermindEth / cairo-vm-go

A virtual machine for Cairo written in Go
MIT License
73 stars 43 forks source link

feat: `usort` hints integration tests #459

Closed TAdev0 closed 2 weeks ago

TAdev0 commented 1 month ago

@cicr99 i checked hints separately locally and it seems fine, except usortBodyCode which is not detected by our VM, just like signedDivRem

We might need to do like lambda go and declare each hint as a const

TAdev0 commented 4 weeks ago

@cicr99 @har777 @MaksymMalicki

Usort integration test is finished. I modified a few things in usort hints:

Let's wait Finalize Segment to be merged to make sure the memory traces match, but i tested outputs and everything against other VMs and its ok

TAdev0 commented 3 weeks ago

@har777 @cicr99 @MaksymMalicki ready for approval/merging

I added a new test for it to make sure multiplicities works well (lambdaclass didnt cover this)

TAdev0 commented 2 weeks ago

@Sh0g0-1758 we already discussed with Carmen the change to uint64 here. If you check in detail, you'll see i changed it always for variable that represents either a length of array or a index in an array. Its ok then