NethermindEth / cairo-vm-go

A virtual machine for Cairo written in Go
MIT License
70 stars 43 forks source link

Fixed a scope bug, updated comments and fixed hint code strings #474

Closed Sh0g0-1758 closed 1 week ago

Sh0g0-1758 commented 2 weeks ago

A couple changes in this one :

  1. DivModNPackedDivmodV1 hint didn't add a , b and N variables in scope, while these are used in the next hint div_mod_n int recover_public_key cairo function
  2. in the hint newVerifyZeroHint in the comments we have written SECP256R1 but its SECP
  3. in the hint newGetPointFromXHint the hint code was not properly formatted so rectified it, both in the comments and in the hintcode.go file
  4. the string for reduceV1Code is also not properly formatted, it does not take into account the extra space after line end