search

NethermindEth / cairo-vm-go

A virtual machine for Cairo written in Go
MIT License
79 stars 49 forks source link

feat: create a separate command to run benchmarks #526

Closed TAdev0 closed 1 month ago

TAdev0 commented 1 month ago

Currently, benchmarks are run each time we do make integration . This lead to the txt file being overwritten again and again.

fmmesen commented 1 month ago

Hello! I'd like to work on this

EmmanuelAR commented 1 month ago

Hello @TAdev0

My name is Emmanuel, a software developer from Costa Rica. I am already working on this repository and would be happy to assist with this task. I will review the current implementation and create a separate command to run the benchmarks.

Please let me know if this is acceptable.

Best regards, Emmanuel 😁

TAdev0 commented 1 month ago

Hi ! @fmmesen you answered first, i guess i'll assign you. Can you work on it and propose a PR before the weekend? otherwise you can work on it @EmmanuelAR so that we can merge this feature before end of week

fmmesen commented 1 month ago

Hello @TAdev0 thank you! I'll start it today

TAdev0 commented 1 month ago

hi @fmmesen any update? would be nice to merge this quickly so that we dont overwrite the benchmark file all the time with all the hints being currently implemented