search

NethermindEth / cairo-vm-go

A virtual machine for Cairo written in Go
MIT License
82 stars 50 forks source link

Feat uint128add hint #582

Closed gadyrcdz closed 4 months ago

gadyrcdz commented 4 months ago

Closes #562

gadyrcdz commented 4 months ago

Hello @TAdev0, I already did the things that you told me, but, I was trying to run the 'make integration' and I have this problem image Do you have any idea how to fix it?

MaksymMalicki commented 4 months ago

did you activate venv before installing the compiler deps?

TAdev0 commented 4 months ago

@gadyrcdz many contributors are having this issue... Can you try using python 3.9.11 ? this will solve the issue

if its not enough, download sympy 1.11 as well

MaksymMalicki commented 4 months ago

Could you please run golangci-lint run and gofmt -w .? This will lint your project

MaksymMalicki commented 4 months ago

Left some minor code style comments, other than that and the conflicts, your PR looks good to me! Congrats! 🚀