search

NethermindEth / cairo-vm-go

A virtual machine for Cairo written in Go
MIT License
82 stars 50 forks source link

Implement `Uint256UnsignedDivRemExpanded` + `Split128` + `Uint128Sqrt` hints #587

Closed MaksymMalicki closed 4 months ago

TAdev0 commented 4 months ago

@MaksymMalicki seems we are missing uint256Sqrt

https://github.com/lambdaclass/cairo-vm/blob/24c2349cc19832fd8c1552304fe0439765ed82c6/vm/src/hint_processor/builtin_hint_processor/hint_code.rs#L337

can you add it in the PR? its basically almost the same as Sqrt hint, but with a low and a high with high == 0

MaksymMalicki commented 4 months ago

@MaksymMalicki seems we are missing uint256Sqrt

https://github.com/lambdaclass/cairo-vm/blob/24c2349cc19832fd8c1552304fe0439765ed82c6/vm/src/hint_processor/builtin_hint_processor/hint_code.rs#L337

can you add it in the PR? its basically almost the same as Sqrt hint, but with a low and a high with high == 0

done