Closed danielcdz closed 4 months ago
I want to know if I'm storing the result of new_state accordingly or if there is a better way to do it 🤔
@danielcdz can you also add unit tests and the corresponding cairo file ?
@TAdev0 sure thing!
I'm having this issue when trying to implement the unit test:
I'm having this issue when trying to implement the unit test:
Hey @danielcdz it's an issue somewhere in the unittests, when creating addr(7)
. I see two problems:
n_bytes
as number (felt) instead of pointer to memory cell 1:7, because t0
argument is expected to be a number.blake2s_start
, which is correct, but you don't populate the memory with any values. Thats probably what causes the issue, you are reading from 1:7, but there is no value inside. You might treat this as referenceI'm having this issue when trying to implement the unit test:
Hey @danielcdz it's an issue somewhere in the unittests, when creating
addr(7)
. I see two problems:
- You need to treat
n_bytes
as number (felt) instead of pointer to memory cell 1:7, becauset0
argument is expected to be a number.- You pass a 1:7 addressto
blake2s_start
, which is correct, but you don't populate the memory with any values. Thats probably what causes the issue, you are reading from 1:7, but there is no value inside. You might treat this as reference
Thanks for the help @MaksymMalicki I'll take a look into it 🫡
@danielcdz can you also move blake_finalize_v3.starknet_with_keccak.cairo file to the folder not in progress? so that we make sure integration tests pass when your hint is involved
@danielcdz can you also move blake_finalize_v3.starknet_with_keccak.cairo file to the folder not in progress? so that we make sure integration tests pass when your hint is involved
@TAdev0 Sure! By not in progress you refer to cairo_zero_hint_tests?
Yes
@TAdev0 this should be good to go! all integration and unit tests are passing
Approve! Good job 🚀
Approve! Good job 🚀
Thank you for the help! you guys are awesome 💯 @TAdev0 @MaksymMalicki @har777
Summary
Closes #539