search

NethermindEth / dotnet-libp2p

A libp2p implementation for .NET in C#.
MIT License
66 stars 26 forks source link

Multiaddress refactor for issue #20 #58

Closed JuanuMusic closed 11 months ago

JuanuMusic commented 11 months ago

Replaced Multiaddr with Multiformats.Multiaddress project. Chat sample working. All tests passing.

SOLVES: https://github.com/NethermindEth/dotnet-libp2p/issues/20

flcl42 commented 11 months ago

Thanks a lot for the contribution! Looks great!

Could you integrate cs-multiaddress as a git submodule? Feel free to add your fork Could you remove that old implementation please? I mean MultiAddr

JuanuMusic commented 11 months ago

Makes sense. I have some updates done on the cs-multiaddress but I think I could implement them as extensions.

Will do!

On Mon, Dec 4, 2023, 06:25 Alexey @.***> wrote:

Thanks a lot for the contribution! Looks great!

Could you integrate cs-multiaddress as a git submodule? Could you remove that old implementation please? I mean MultiAddr https://github.com/JuanuMusic/dotnet-libp2p/blob/multiaddress-refactor/src/libp2p/Libp2p.Core/Multiaddr.cs

— Reply to this email directly, view it on GitHub https://github.com/NethermindEth/dotnet-libp2p/pull/58#issuecomment-1838145836, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAN2GXFZW6HDMCZ7REUKWJLYHWJIJAVCNFSM6AAAAABAECUBFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZYGE2DKOBTGY . You are receiving this because you authored the thread.Message ID: @.***>

JuanuMusic commented 11 months ago

Lets hold off on Merging. I found a couple issues running PubsubChat.

@flcl42 @rubo @chertby does the Libp2p.Protocols.Quic protocol support QUIC as well as QUICv1 ?

flcl42 commented 11 months ago

Lets hold off on Merging. I found a couple issues running PubsubChat.

@flcl42 @rubo @chertby does the Libp2p.Protocols.Quic protocol support QUIC as well as QUICv1 ?

quic is obsolete, there are no plans to support it and it has never been tested.

JuanuMusic commented 11 months ago

Understood. Im gettng errors actuallly by .net7 not having support for it. Ill push the PR then and we can move forward from there.

flcl42 commented 11 months ago

Understood. Im gettng errors actuallly by .net7 not having support for it. Ill push the PR then and we can move forward from there.

It may work, but you need to customize your .NET: https://github.com/NethermindEth/dotnet-libp2p/blob/main/src/libp2p/Libp2p.Protocols.Quic/README.md. It's a pity that we need such manipulations, but for now it's the only way and a known .NET issue.

JuanuMusic commented 11 months ago

@flcl42 Looks like the tests failed because of a Server error on nuget. Might have been a temporary issue on their servers? I am running it and it works perfectly. Can you trigger the checks again? image

JuanuMusic commented 11 months ago

Hmmm I added it as a git submodule, but looks like its just taking it as files from the same repo. Do you need me to do anything or this is good to be merged?

flcl42 commented 11 months ago

Merged! Thanks a lot!