search

NethermindEth / dotnet-libp2p

A libp2p implementation for .NET in C#.
MIT License
53 stars 19 forks source link

Issue#63 - Adding Nullable checks #74

Open shubham-sonthalia opened 4 months ago

shubham-sonthalia commented 4 months ago
Screenshot 2024-02-23 at 11 04 28 AM
shubham-sonthalia commented 4 months ago

Hi @rubo @flcl42 kindly review the PR for resolving the build warnings for nullable references.

shubham-sonthalia commented 4 months ago

Hey @flcl42, for the solution level, I was previously getting 60 warnings. I have reduced them down to 25 now. But now, I am not sure about the null checks because they are causing some other issues when adding nullables there.

flcl42 commented 4 months ago

Hey @flcl42, for the solution level, I was previously getting 60 warnings. I have reduced them down to 25 now. But now, I am not sure about the null checks because they are causing some other issues when adding nullables there.

You can propose solution and let me help you with comments