NethermindEth / juno

Starknet client implementation.
https://juno.nethermind.io
Apache License 2.0
397 stars 172 forks source link

Unix socket support #1277

Open Exca-DK opened 1 year ago

Exca-DK commented 1 year ago

Issue

Currently, jsonrpc only supports http and ws.

Rationale

Why should this feature exist? Unix socket support would enhance the project by providing a more secure and efficient communication mechanism. Unix sockets typically have lower latency and higher throughput than TCP. This feature is particularly useful when hosting multiple users on the same machine since access can be easly restricted.

Implementation

Do you have ideas regarding the implementation of this feature? yes Are you willing to implement this feature? yes

Scope:

Additional Information:

Windows would require downloading another package.

joshklop commented 1 year ago

Some notes:

Windows would require downloading another package.

We can skip Windows support for now. We only test on Linux and MacOS.

Adding cli-flags (unix-enabled and unix-path).

Can we use ipc (similar to our http and ws flags) and ipc-path? This gives us the option to add Windows support later without changing the name of the flag.

Exca-DK commented 1 year ago

Sure, I will start working on that.