Pending Block and State can become out of sync

NethermindEth / juno

Starknet client implementation.

https://juno.nethermind.io

Apache License 2.0

371 stars 157 forks source link

Pending Block and State can become out of sync #1789

Open IronGauntlets opened 2 months ago

IronGauntlets commented 2 months ago

Pending Block and State are written to the DB this means that any subsequent runs of Juno when pending-poll is disabled would have access to the old Pending Block and State which is no longer relevant.

There are 2 solutions:

Stop persisting the pending block and state across multiple runs of Juno and only manage it in memory. This may require a migration to remove the old pending block.
Check if the pending block is outdated and return ErrBlockNotFound.

IronGauntlets commented 2 months ago

This should be done along with #1787