search

NethermindEth / juno

Starknet client implementation.
https://juno.nethermind.io
Apache License 2.0
386 stars 169 forks source link

Replace the Goerli network with Sepolia in the test TestRpcBlockAdaption #1797

Closed stefanalfbo closed 4 months ago

stefanalfbo commented 5 months ago

This includes adding a block and a signature json-file to the testdata directory for the Sepolia network.

This PR is fixing the issue #1796.

pnowosie commented 5 months ago

@stefanalfbo Great work, thank you for contributing to juno! ❤️

Please note that previous PR (#1768) has spread rpc handlers tests into several file. Kindly request to rebase your work onto current main and push again.

Thank you 🙏

stefanalfbo commented 5 months ago

This one has been rebased on current main now @pnowosie.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.18%. Comparing base (a923c90) to head (4c9e192).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1797 +/- ## ========================================== + Coverage 75.11% 75.18% +0.06% ========================================== Files 96 96 Lines 8183 8183 ========================================== + Hits 6147 6152 +5 + Misses 1513 1509 -4 + Partials 523 522 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pnowosie commented 4 months ago

This PR will be merge to main as a part of #1861