search

NethermindEth / juno

Starknet client implementation.
https://juno.nethermind.io
Apache License 2.0
386 stars 169 forks source link

Change to the network Sepoli and Sepolia-integration for the TestBlockWithTxHashes tests #1812

Closed stefanalfbo closed 4 months ago

stefanalfbo commented 5 months ago

There is also new testdata files for the sepolia integration network that is used by the TestBlockWithTxHashesV013.

This PR is fixing the issue #1811

pnowosie commented 5 months ago

@stefanalfbo Great work, thank you for contributing to juno! ❤️

Please note that previous PR (#1768) has spread rpc handlers tests into several file. Kindly request to rebase your work onto current main and push again.

Thank you 🙏

stefanalfbo commented 5 months ago

@pnowosie this one should also be rebased onto the current main now, BTW I like the refactoring of the rpc handlers :+1:

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.18%. Comparing base (a923c90) to head (6ba427f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1812 +/- ## ========================================== + Coverage 75.11% 75.18% +0.06% ========================================== Files 96 96 Lines 8183 8183 ========================================== + Hits 6147 6152 +5 + Misses 1513 1508 -5 Partials 523 523 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pnowosie commented 4 months ago

This PR will be merge to main as a part of #1861