search

NethermindEth / juno

Starknet client implementation.
https://juno.nethermind.io
Apache License 2.0
371 stars 157 forks source link

Manage pending in memory and move it to synchroniser #1844

Open IronGauntlets opened 2 months ago

IronGauntlets commented 2 months ago

Fixes parts of #1789. A migration to remove the pending from DB is still outstanding.

It would be best to review the commits individually and in order.

IronGauntlets commented 2 months ago

This also fixes #1450

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 68.50394% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 74.98%. Comparing base (619fffd) to head (09e6778).

Files Patch % Lines
rpc/transaction.go 52.50% 14 Missing and 5 partials :warning:
sync/sync.go 63.46% 15 Missing and 4 partials :warning:
blockchain/event_filter.go 85.71% 0 Missing and 1 partial :warning:
rpc/helpers.go 90.90% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1844 +/- ## ========================================== + Coverage 74.92% 74.98% +0.05% ========================================== Files 96 96 Lines 8183 8114 -69 ========================================== - Hits 6131 6084 -47 + Misses 1523 1513 -10 + Partials 529 517 -12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

IronGauntlets commented 2 months ago

Since I will be away for 2 weeks. Please "Rebase and Merge" once it is approved.