NethermindEth / juno

Starknet client implementation.
https://juno.nethermind.io
Apache License 2.0
371 stars 158 forks source link

Rianhughes/sequencer #1863

Open rianhughes opened 1 month ago

rianhughes commented 1 month ago

Merging https://github.com/NethermindEth/juno/compare/main...feature/sequencer into main, by cherry-picking

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 64.58658% with 227 lines in your changes missing coverage. Please review.

Project coverage is 74.65%. Comparing base (1ae9019) to head (c2e61b3). Report is 10 commits behind head on main.

:exclamation: Current head c2e61b3 differs from pull request most recent head 856a438

Please upload reports for the commit 856a438 to get more accurate results.

Files Patch % Lines
builder/builder.go 71.92% 30 Missing and 18 partials :warning:
genesis/genesis.go 55.17% 25 Missing and 14 partials :warning:
mempool/mempool.go 70.94% 19 Missing and 15 partials :warning:
blockchain/blockchain.go 70.23% 11 Missing and 14 partials :warning:
node/node.go 54.00% 17 Missing and 6 partials :warning:
rpc/transaction.go 13.04% 18 Missing and 2 partials :warning:
node/genesis.go 0.00% 18 Missing :warning:
blockchain/pending.go 82.92% 4 Missing and 3 partials :warning:
rpc/handlers.go 83.33% 2 Missing and 2 partials :warning:
utils/clone.go 42.85% 2 Missing and 2 partials :warning:
... and 2 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1863 +/- ## ========================================== - Coverage 75.39% 74.65% -0.75% ========================================== Files 97 103 +6 Lines 8333 8870 +537 ========================================== + Hits 6283 6622 +339 - Misses 1518 1653 +135 - Partials 532 595 +63 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rianhughes commented 1 month ago

Note for self: global state root seems to change every block, after the 10th block, despite no transactions???