search

NethermindEth / juno

Starknet client implementation.
https://juno.nethermind.io
Apache License 2.0
371 stars 158 forks source link

DO_NOT_MERGE Exercise 6 #1879

Open ashu26jha opened 1 month ago

ashu26jha commented 1 month ago

New Sync package using feeder gateway

rianhughes commented 1 month ago

Generally it looks pretty good, although I would recommend fixing the tests.

ashu26jha commented 4 weeks ago

Hey @rianhughes, smoke test (syncing first 100 blocks) are working 🎉, but there are some issues I would like to highlight

  1. Can't fix all the lints as http is not added to ignore (could be fixed by adding //nolint comment)
  2. It only works with mainnet

Should I try fixing these or move on?

PS:

I also added verifier_Task again just to have the sanity checks, this is my logs when synching:

09:08:46.663 29/05/2024 +05:30  INFO    sync/sync.go:174        Fetching from feeder
09:08:49.010 29/05/2024 +05:30  INFO    sync/sync.go:182        Stored Block    {"number": 0, "hash": "0x47c3...e943", "root": "0x2187...dee6"}
09:08:49.010 29/05/2024 +05:30  INFO    sync/sync.go:174        Fetching from feeder
09:08:50.067 29/05/2024 +05:30  INFO    sync/sync.go:182        Stored Block    {"number": 1, "hash": "0x2a70...fdeb", "root": "0x525a...ac32"}
09:08:50.067 29/05/2024 +05:30  INFO    sync/sync.go:174        Fetching from feeder
09:08:51.195 29/05/2024 +05:30  INFO    sync/sync.go:182        Stored Block    {"number": 2, "hash": "0x4e1f...f2f6", "root": "0x3cee...38d9"}
09:08:51.195 29/05/2024 +05:30  INFO    sync/sync.go:174        Fetching from feeder
09:08:52.727 29/05/2024 +05:30  INFO    sync/sync.go:182        Stored Block    {"number": 3, "hash": "0x3dc0...9a74", "root": "0x79ea...6aea"}
09:08:52.727 29/05/2024 +05:30  INFO    sync/sync.go:174        Fetching from feeder
09:08:53.994 29/05/2024 +05:30  INFO    sync/sync.go:182        Stored Block    {"number": 4, "hash": "0x2ab4...5848", "root": "0x4022...3eb7"}
09:08:53.994 29/05/2024 +05:30  INFO    sync/sync.go:174        Fetching from feeder
09:08:55.185 29/05/2024 +05:30  INFO    sync/sync.go:182        Stored Block    {"number": 5, "hash": "0xdcbd...97d3", "root": "0x1193...f17d"}
09:08:55.185 29/05/2024 +05:30  INFO    sync/sync.go:174        Fetching from feeder
09:08:56.309 29/05/2024 +05:30  INFO    sync/sync.go:182        Stored Block    {"number": 6, "hash": "0x680d...f899", "root": "0x418a...1813"}
09:08:56.309 29/05/2024 +05:30  INFO    sync/sync.go:174        Fetching from feeder
^C09:08:56.763 29/05/2024 +05:30        INFO    node/node.go:350        Shutting down Juno...