search

NethermindEth / juno

Starknet client implementation.
https://juno.nethermind.io
Apache License 2.0
371 stars 158 forks source link

Sort buffered transactions #1882

Open ashu26jha opened 4 weeks ago

ashu26jha commented 4 weeks ago

Implements #903, sorting the buffered txns in the increasing contract addresses. They do give slightly better benchmarking results

Benchmarks from the main branch:

ashutoshjha@Ashutoshs-MacBook-Air juno % go test ./... -bench=MainnetBlock -benchmem
PASS
ok      github.com/NethermindEth/juno/adapters/sn2core  0.920s

Benchmarks from current branch

ashutoshjha@Ashutoshs-MacBook-Air juno % go test ./... -bench=MainnetBlock -benchmem
PASS
ok      github.com/NethermindEth/juno/adapters/sn2core  0.727s
codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.49%. Comparing base (1f15377) to head (a13f99c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1882 +/- ## ========================================== + Coverage 75.30% 75.49% +0.19% ========================================== Files 97 97 Lines 8332 8340 +8 ========================================== + Hits 6274 6296 +22 + Misses 1522 1515 -7 + Partials 536 529 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.