NethermindEth / juno

Starknet client implementation.
https://juno.nethermind.io
Apache License 2.0
371 stars 158 forks source link

node: include semantic version in agent version #1906

Open weiihann opened 1 week ago

weiihann commented 1 week ago

This PR adds the semantic version of the node to the user agent version such that it follows the appropriate format, as shown in the Starknet P2P specifications.

Before: juno After: juno/<semantic-version>

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.49%. Comparing base (4e6dcd7) to head (a97ac21).

Files Patch % Lines
node/node.go 62.50% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1906 +/- ## ========================================== + Coverage 75.43% 75.49% +0.05% ========================================== Files 97 97 Lines 8342 8349 +7 ========================================== + Hits 6293 6303 +10 + Misses 1519 1518 -1 + Partials 530 528 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.