search

NethermindEth / juno

Starknet client implementation.
https://juno.nethermind.io
Apache License 2.0
402 stars 170 forks source link

make it clear that `MaxFee` field is not used anymore for V3 tx + improve comments for Transactions #2130

Closed TAdev0 closed 4 days ago

TAdev0 commented 2 months ago

Closes #2129

also reorganize fields to make it clearer in general

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.31%. Comparing base (71c7ca2) to head (299f1e3). Report is 88 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2130 +/- ## ========================================== - Coverage 78.33% 78.31% -0.03% ========================================== Files 100 100 Lines 9221 9221 ========================================== - Hits 7223 7221 -2 Misses 1357 1357 - Partials 641 643 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 5 days ago

This pull request is stale because it has been open 35 days with no activity. Remove stale label or comment or this will be closed in 14 days.